cullmann added a comment.
I think one reason for the early out was that actually even the "isXXX" checks are very expensive, at least if I remember correctly they did show up a lot in my profiling in the past. Perhaps one should profile this once more (and if still visible) at least skip all the isXXX checks for the isDefault... case. Otherwise I have no issues with this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21295 To: dhaumann, vkrause, cullmann, kossebau Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
