dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land.
I ngeneral looks good to me. Maybe use ecm_optional_add_subdirectory - this also allows 3rd party users to omit the code and it still works. INLINE COMMENTS > CMakeLists.txt:6 > + > +add_subdirectory(codepdfprinter) Maybe we use the optional variant like: ecm_optional_add_subdirectory (codepdfprinter) REPOSITORY R216 Syntax Highlighting BRANCH addpdfprintingexample REVISION DETAIL https://phabricator.kde.org/D21298 To: kossebau, vkrause, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
