bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:43
>  
>  // copied from kio/src/core/ksambashare.cpp, 
> KSambaSharePrivate::isSambaInstalled()
>  static bool isSambaInstalled()

see here ^

`net` is not checked for at all, it just tries to execute it using 
`QProcess::start("net", args)`

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

Reply via email to