bruns added inline comments. INLINE COMMENTS
> delegate.cpp:46 > + connect(comboBox, QOverload<int>::of(&QComboBox::activated), > + this, &UserPermissionDelegate::emitCommitData); > use a lambda here: - avoids the single-use `emitCommitData` wrapper - avoids the need for `qobject_cast<QWidget*>(sender())`, which is the combobox (just capture it). REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21354 To: ngraham, #frameworks, apol Cc: bruns, aacid