cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, this is a good start!
  
  Thanks for taking care of this.
  
  I think to get the "default font", you need to call 
KateRendererConfig::global()->font() instead of using a default constructed 
QFont. That should return the font configured in the KTextEditor settings.
  
  For the shortcut: I guess you should use KStandardShortcut::ActualSize().
  
  As we now have three actions just for zooming I think some "Zoom" sub-menu 
would be nice.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21412

To: kishoreg, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

Reply via email to