ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Works perfectly and the code looks sensible! INLINE COMMENTS > meven wrote in kdiroperator.cpp:1955 > Well there are pretty much reusable already, their actions are available in > the actionCollection, although not documented. > > But reusing kdiroperator in dolphin is another matter. > The views here are simply based on existing kdiroperator views and most of > their bugs and features gaps with Dolphin remains. Yeah, I'm afraid it isn't possible without putting KDirOperator back into Dolphin, which was removed on purpose many years ago. I like to see Dolphin once again use a re-usable component too, but that's outside the scope of this patch. REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
