fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision.
REVISION SUMMARY ThreadWeaver Job Decorators don't actually hook into an existing job. Instead, they provide the same interface as the job and just pass through all calls. The way the QObjectDecorator is used by KRunner results in no signals actually getting emitted, making most of the code pointless. This patch is just a quick hack to show what would happen if the jobDone signal worked and is mostly intended to present the issue. TEST PLAN jobDone is called now. REPOSITORY R308 KRunner BRANCH hack REVISION DETAIL https://phabricator.kde.org/D21606 AFFECTED FILES src/runnerjobs.cpp To: fvogt Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns