arrowd added inline comments.

INLINE COMMENTS

> xattr_p.h:204
> +    #elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD)
> +    const ssize_t size = extattr_list_file(encodedPath, 
> EXTATTR_NAMESPACE_USER, attributeName, nullptr, 0);
> +    #endif

error: use of undeclared identifier 'attributeName'

> xattr_p.h:231
> +    #elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD)
> +        const ssize_t size = extattr_list_file(encodedPath, 
> EXTATTR_NAMESPACE_USER, data.data(), data.size());
> +    #endif

Ditto.

Also, `size` should be `r`, probably, see below.

> xattr_p.h:234
> +
> +        if (r == 0) {
> +            return UserMetaData::Attribute::None;

error: use of undeclared identifier 'r'

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Reply via email to