poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land.
Apart from small nitpick, I think it's fine. INLINE COMMENTS > fileindexscheduler.h:131 > bool m_isGoingIdle; > + bool m_isSuspended = false; > }; I think it's inconvenient to scatter default values all around various places - just initialize it in the constructor like everything else. REPOSITORY R293 Baloo BRANCH scheduler REVISION DETAIL https://phabricator.kde.org/D21673 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
