brute4s99 added inline comments. INLINE COMMENTS
> pino wrote in notifybysnore.cpp:84 > if the notification is not found, this will be an uninitialized pointer; TBH > if the search for the notification with the specified id fails, then it > should be better to return earlier, as it means the notification is unknown well, I just found out the patch had broken functionality that I fixed just after putting here an `else return`! 😆 > pino wrote in notifybysnore.cpp:168-171 > the logic here is swapped: if `waitForStarted()` returns false, that means > the process did not start successfully; also, after `finish()` you must > return earlier (do not forget to delete the process), otherwise the rest of > the code does things as if the process run fine I'm removing this code chunk because we already check for successful show of notif in the following `connect`. > pino wrote in notifybysnore.cpp:44 > > if you could guide me on how to update the docs on the website, that'd be > > great! > > which website? https://api.kde.org/frameworks/knotifications/html/index.html REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
