dfaure requested changes to this revision.
dfaure added inline comments.
INLINE COMMENTS
> slavebase.cpp:1511
> + KIO_DATA << d->m_warningCaption << d->m_warningMessage <<
> privilegeOperationDetails;
> + send(INF_PRIVILEGE_CONF, data);
> + if (waitForAnswer(INF_PRIVILEGE_CONF, 0, data) != -1) {
INF is for one-way information, isn't it? Why isn't this MSG_ like the one
above?
> slavebase.h:964
>
> + QString privilegeOperationDetails;
> +
Missing "m" prefix like the other members, but wait.... isn't this BIC? Adding
a new member to an exported class certainly is. This needs to go into the
SlaveBasePrivate class instead.
> file_unix.cpp:85
> + switch(actionType) {
> + case CHMOD: {
> + action = i18n("Change File Permissions");
all those { ... } braces are unnecessary in this switch, which doesn't define
any new variables
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21783
To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
