aspotashev added a comment.
Dammit, I'm still not on the same page with the review request.
In fact you had to trust your unit test and go fix the code :)
diff --git a/src/klocalizedstring.cpp b/src/klocalizedstring.cpp
index b1ba745..fed5b8a 100644
--- a/src/klocalizedstring.cpp
+++ b/src/klocalizedstring.cpp
@@ -1198,7 +1198,7 @@ KLocalizedString KLocalizedString::subs(double a, int
fieldWidth,
QChar fillChar) const
{
KLocalizedString kls(*this);
- kls.d->arguments.append(QStringLiteral("%1").arg(a, fieldWidth,
format, precision, fillChar));
+ kls.d->arguments.append(QStringLiteral("%L1").arg(a, fieldWidth,
format, precision, fillChar));
kls.d->values.append(static_cast<realn>(a));
return kls;
}
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D22069
To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh,
ngraham, bruns
