apol added inline comments. INLINE COMMENTS
> fvogt wrote in svg.cpp:317 > `isValid` is always true, you probably want to use `hasMatch` instead. > > This is not obvious, I only noticed this because I debugged this error before > (https://phabricator.kde.org/D17359) Please note this is only to make sure the regex was properly compiled. It isn't matching there yet. > tcanabrava wrote in svg.cpp:342-349 > looks a good example of code that could be written with an std::find_if I'm not sure, this loop goes through all the size hints. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22147 To: apol, #plasma, #frameworks, fvogt Cc: tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
