mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision.
REVISION SUMMARY Don't call blockSignals, but instead, to avoid an infinite signal chain, check KCoreConfigSkeleton::configChanged wasn't emitted by ourselves writing on the config. Plasma::Applet::configChanged() slot was never invoked when config was written from QML, which is wrong. TEST PLAN Config still loads, plasma which makes heavy use of this still loads and saves configs correctly, no infinite signal/slot recursions. Now if somebody connects to KCoreConfigSkeleton::configChanged from outside of this class, it wil lreceive correct signals when somebody writes to the config from QML. REPOSITORY R296 KDeclarative BRANCH blocksignals REVISION DETAIL https://phabricator.kde.org/D22250 AFFECTED FILES src/kdeclarative/configpropertymap.cpp To: mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
