apol added a comment.
Other than that LGTM INLINE COMMENTS > personsmodel.h:60 > + UserRole = Qt::UserRole + 0x1000, ///< in case it's needed to > extend, use this one to start from > + PhoneNumberRole > }; Put it after GroupsRole REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
