cgiboudeaux added inline comments. INLINE COMMENTS
> KF5I18nMacros.cmake.in:72 > + if(TARGET ${_sources}) > + cmake_minimum_required(VERSION 3.1) > + target_sources(${_sources} PRIVATE ${_header}) same thing as D22699 <https://phabricator.kde.org/D22699>. A macro must not change the minimum required version. (ki18n already requires CMake 3.5 anyway) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns