meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS
> ivan wrote in resultset.cpp:182 > setDate above is by value, here it is const-ref. Check for the size of the > type and decide on one of these. QDate size is 8 byte, so on most systems nowadays it will equal to a ref size, so I am opting towards the simpler and more stable one : by value. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
