aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision.
REVISION SUMMARY There's nothing the caller of this function can do to control the assert condition, so asserting is "too rude", and on top of that there's a perfectly valid if below that already handles the condition properly REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22751 AFFECTED FILES src/ktar.cpp To: aacid Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns