vkrause added inline comments.

INLINE COMMENTS

> CMakeLists.txt:127
>  add_subdirectory(src)
> -if (BUILD_TESTING)
> +if (TARGET QT5::DBus AND BUILD_TESTING)
>      add_subdirectory(autotests)

Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the 
tests for everyone I think. Apart from that, +2.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Reply via email to