cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land.
Seems reasonable, thanks for taking care ;=) I you use the vi mode, we have more open vi mode bugs that need some love: https://bugs.kde.org/buglist.cgi?bug_severity=critical&bug_severity=grave&bug_severity=major&bug_severity=crash&bug_severity=normal&bug_severity=minor&bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&list_id=1655504&order=component%20DESC%2Cbug_status%20DESC%2Cbug_severity%2Cpriority%2Cassigned_to%2Cbug_id&product=frameworks-ktexteditor&product=kate&query_format=advanced (vi input component) We have some hack to fix one of them here, that needs some research: https://phabricator.kde.org/D19408 REPOSITORY R39 KTextEditor BRANCH fix/vim_mode_accept_0_as_line_index (branched from master) REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann