cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
I would tend to make more stuff "static const QRegularExpression", given QRegularExpression unlike QRegExp has not the issue of storing matches inside itself. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23385 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann