nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision.
REVISION SUMMARY In syntax highlighting XML files, it doesn't work to turn off attributes, for example: `bold="0"`, `italic="0"` or `underline="0"`. This is fixed, but only for KSyntaxHighlighting themes, that is, this continues to not work in "KDE" and "Vim (dark)". To correct that it is necessary to add to the API of the `KSyntaxHighlighting::Format` class, methods such as `hasBold()`, `hasItalic()`, etc. to know if the attributes "bold", "italic", "underline" & "strikeout" are modified in the XML file (the methods `isBold(...)`, `isItalic(...)`, etc., return the combination between the syntax definition and the theme). REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D23422 AFFECTED FILES src/syntax/katehighlight.cpp To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
