dfaure added inline comments.
INLINE COMMENTS
> recentlyused.cpp:186
> +{
> + qCDebug(KIO_RECENTLYUSED_LOG) << "udsEntryFromResource" << " " <<
> resource;
> +
You don't need spaces between items, when using q[C]Debug
> meven wrote in recentlyused.h:57
> It is path currently due to limitation in RecentlyUsed::udsEntryFromResource
> being able to create valid UDS::Entry only for files.
> But it could evolve later to support any url that the sqlite database
> ~/.local/share/kactivitymanagerd/resources/database stores in its
> targettedResource column, including ioslave urls, kcm urls, applications
> desktop files...
If you want this to support non-local URLs one day then it should probably take
URLs already now.
Alternatively call the argument "path" and leave "url" for later.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D22144
To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela,
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham,
andrebarros, bruns, emmanuelp, mikesomov
