apol added a comment.

  Can you look into kossebau's coment? Let's get this in once that's ironed out.

INLINE COMMENTS

> CMakeLists.txt:30
>  
> +if (${Qt5Qml_FOUND})
> +    ecm_add_tests(

I like `if (TARGET Qt5::Qml)` better.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D21328

To: davidedmundson
Cc: kossebau, vkrause, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Reply via email to