dfaure created this revision. dfaure added reviewers: cgiboudeaux, sitter. Herald added projects: Frameworks, Build System. dfaure requested review of this revision.
REVISION SUMMARY The user of this find module has to do it, so that they can specify the purpose of using canberra in their application. We can't do it twice, it leads to - Warning: Property DESCRIPTION for package Canberra already set to "Event sound library", overriding it with "Library for generating event sounds" The documentation for FeatureSummary always does find_package and then set_package_properties, i.e. it was never meant for the finder to do this. TEST PLAN knotifications no longer warns REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D23552 AFFECTED FILES find-modules/FindCanberra.cmake To: dfaure, cgiboudeaux, sitter Cc: kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns