kossebau added a comment.
@zzag Actually, while you commented on that one loop only, the same would be valid also for other loops touched in the patch. So, do you want const ref with all of them? As you can see by the existing code, it also already used values, not const ref, surely also for the reasons I gave. So, how much do you prefer const ref just for reading patterns? Shall I change also all the orher places? Or is there a chance you can be won for value types in for loops where of runtime advantage? :) REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23839 To: kossebau, #kwin, zzag Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns