ngraham added inline comments.
INLINE COMMENTS
> klistopenfilesjobtest_unix.cpp:37
> + QProcess lsofProcess;
> + lsofProcess.start(QStringLiteral("lsof"),
> QStringList(QStringLiteral("-v")));
> + lsofProcess.waitForFinished();
A prior career in build engineering tells me that this will start failing in 10
years when `lsof` removes the `-v` argument and replaces it with `--version`.
For robustness' sake, I would additionally check for `--version` (and possibly
even `-version` too) if the initial `lsof -v` call fails.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D23884
To: hallas, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
