dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > slavebase.cpp:38 > > +#include <QtGlobal> > #include <QFile> what is this used for? > meven wrote in slavebase.cpp:281 > That's on purpose, the first use of mapConfig is in rebuildConfig and is a > clear() call. So? This line is not needed, an empty map is an empty map, no need to assign an empty map to it. > dfaure wrote in slavebase.h:342 > missing @since Time passed, this is for 5.63 now, sorry about that. > dfaure wrote in slavebase.h:353 > @deprecated since 5.xx @deprecated since 5.63, use mapConfig() instead. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
