ndavis added a comment.
In D23942#531279 <https://phabricator.kde.org/D23942#531279>, @guoyunhe wrote: > @ndavis, @broulik, @ngraham, I made some change. Can you have another look? I just noticed that the "No" symbol is backwards. Once you fix that and the hardcoded colors, this patch will be ready to land. INLINE COMMENTS > font-disable.svg:11 > + <path class="ColorScheme-Text" d="m6.3828 2-4.3828 > 11h1.3574l1.1895-3h2.4531 2.3418a3.5 3.5 0 0 1 > 1.0234-1.2715l-2.6797-6.7285h-0.68555-0.61719zm0.62305 1.3281 2.1211 > 5.6719h-2.127-2.0586c-0.00124 0.00746 2.0645-5.6719 2.0645-5.6719z" > fill="currentColor"/> > + <path class="ColorScheme-NegativeText" d="m12.5 9a2.5 2.5 0 0 0-2.5 2.5 > 2.5 2.5 0 0 0 2.5 2.5 2.5 2.5 0 0 0 2.5-2.5 2.5 2.5 0 0 0-2.5-2.5m0 1a1.5 1.5 > 0 0 1 0.64453 0.14844l-1.9965 1.9966a1.5 1.5 0 0 1-0.148-0.645 1.5 1.5 0 0 1 > 1.5-1.5m1.3516 0.85547a1.5 1.5 0 0 1 0.14844 0.64453 1.5 1.5 0 0 1-1.5 1.5 > 1.5 1.5 0 0 1-0.64453-0.14844z" fill="#da4453"/> > +</svg> Hardcoded color > font-disable.svg:10 > + </style> > + <path class="ColorScheme-NegativeText" d="m16 13c-1.662 0-3 1.338-3 > 3s1.338 3 3 3 3-1.338 3-3-1.338-3-3-3zm0 1c0.37162 0 0.7142 0.10606 1.0117 > 0.28125l-2.7305 2.7305c-0.17518-0.29752-0.28125-0.64009-0.28125-1.0117 > 0-1.108 0.892-2 2-2zm1.7188 0.98828c0.17518 0.29752 0.28125 0.64009 0.28125 > 1.0117 0 1.108-0.892 2-2 2-0.37162 0-0.7142-0.10606-1.0117-0.28125z" > fill="#da4453"/> > + <path class="ColorScheme-Text" d="m7.9102 3-3.3145 9.5938-0.12305 > 0.40625-1.4727 4h1.6582l1.625-4.4375h5.4336l0.65039 1.7754a4 4 0 0 1 > 1.125-1.4531l-0.087891-0.29102-3.3145-9.5938h-0.21484-1.75-0.21484zm1.1055 > 1.9375 2.1797 6.3438h-4.3906l2.2109-6.3438z" fill="currentColor"/> Hardcoded color > font-disable.svg:11 > + <path class="ColorScheme-Text" d="m6.3828 2-4.3828 > 11h1.3574l1.1895-3h2.4531 2.3418a3.5 3.5 0 0 1 > 1.0234-1.2715l-2.6797-6.7285h-0.68555-0.61719zm0.62305 1.3281 2.1211 > 5.6719h-2.127-2.0586c-0.00124 0.00746 2.0645-5.6719 2.0645-5.6719z" > fill="currentColor"/> > + <path class="ColorScheme-NegativeText" d="m12.5 9a2.5 2.5 0 0 0-2.5 2.5 > 2.5 2.5 0 0 0 2.5 2.5 2.5 2.5 0 0 0 2.5-2.5 2.5 2.5 0 0 0-2.5-2.5m0 1a1.5 1.5 > 0 0 1 0.64453 0.14844l-1.9965 1.9966a1.5 1.5 0 0 1-0.148-0.645 1.5 1.5 0 0 1 > 1.5-1.5m1.3516 0.85547a1.5 1.5 0 0 1 0.14844 0.64453 1.5 1.5 0 0 1-1.5 1.5 > 1.5 1.5 0 0 1-0.64453-0.14844z" fill="#da4453"/> > +</svg> Hardcoded color > font-disable.svg:10 > + </style> > + <path class="ColorScheme-NegativeText" d="m16 13c-1.662 0-3 1.338-3 > 3s1.338 3 3 3 3-1.338 3-3-1.338-3-3-3zm0 1c0.37162 0 0.7142 0.10606 1.0117 > 0.28125l-2.7305 2.7305c-0.17518-0.29752-0.28125-0.64009-0.28125-1.0117 > 0-1.108 0.892-2 2-2zm1.7188 0.98828c0.17518 0.29752 0.28125 0.64009 0.28125 > 1.0117 0 1.108-0.892 2-2 2-0.37162 0-0.7142-0.10606-1.0117-0.28125z" > fill="#da4453"/> > + <path class="ColorScheme-Text" d="m7.9102 3-3.3145 9.5938-0.12305 > 0.40625-1.4727 4h1.6582l1.625-4.4375h5.4336l0.65039 1.7754a4 4 0 0 1 > 1.125-1.4531l-0.087891-0.29102-3.3145-9.5938h-0.21484-1.75-0.21484zm1.1055 > 1.9375 2.1797 6.3438h-4.3906l2.2109-6.3438z" fill="currentColor"/> Hardcoded color REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
