hwti added a comment.
In D24150#536113 <https://phabricator.kde.org/D24150#536113>, @aacid wrote: > why the void? do you get a warning otherwise? No, but it is used in several places in the repository (and in Qt), so I suppose it might generate one depending on the compiler. > Also a comment in that line quoting the Qt docs "Note that you should not delete codecs yourself: once created they become Qt's responsibility." makes sense IMHO otherwise someone will move it back to the old code to not have a leak OK, done (but the void should already show that not storing it in a variable, so not deleting it, is deliberate). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24150 To: hwti, cfeck, dfaure, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
