dfaure created this revision. dfaure added reviewers: bruns, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY This was done using clang-tidy's modernize-loop-convert, then clazy (for qAsConst), then manual cleanups (less auto, better variable names, etc). Took way longer than I was hoping for... TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24160 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/core/authinfo.cpp src/core/desktopexecparser.cpp src/core/hostinfo.cpp src/core/kcoredirlister.cpp src/core/kioglobal_p.cpp src/core/kmountpoint.cpp src/core/kprotocolmanager.cpp src/core/krecentdocument.cpp src/core/ksambashare.cpp src/core/ksslcertificatemanager.cpp src/core/slave.cpp src/core/udsentry.cpp src/filewidgets/kdirsortfilterproxymodel.cpp src/filewidgets/knewfilemenu.cpp src/ioslaves/help/kio_help.cpp src/ioslaves/http/http.cpp src/ioslaves/trash/kio_trash.cpp src/ioslaves/trash/tests/testtrash.cpp src/ioslaves/trash/trashimpl.cpp src/kcms/kio/smbrodlg.cpp src/kcms/webshortcuts/main.cpp src/kiod/kiod_main.cpp src/kntlm/kntlm.cpp src/kpac/proxyscout.cpp src/kssld/kssld.cpp src/urifilters/ikws/kuriikwsfiltereng.cpp src/widgets/dropjob.cpp src/widgets/fileundomanager.cpp src/widgets/kfileitemdelegate.cpp src/widgets/kopenwithdialog.cpp src/widgets/kpropertiesdialog.cpp src/widgets/krun.cpp src/widgets/kshellcompletion.cpp src/widgets/ksslinfodialog.cpp src/widgets/kurifilter.cpp src/widgets/kurlcompletion.cpp src/widgets/kurlrequester.cpp src/widgets/previewjob.cpp tests/getalltest.cpp tests/previewtest.cpp To: dfaure, bruns, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
