cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land.
Seems reasonable, thanks I think it would be nice to have a comment added to the 612 613 /** 613 /** 614 * no match 614 * no match 615 */ 615 */ 616 return MatchResult(offset, result.capturedStart()); part with reference to the issue. Then please commit. REPOSITORY R216 Syntax Highlighting BRANCH d399388 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24179 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann