volkov added inline comments. INLINE COMMENTS
> aacid wrote in kauthunixfiledescriptor.h:33 > Does this class really need to be exported and its header installed? > > Seems like this is implementation detail? Who would use this header? It's needed to mark file descriptors in QVariantMap. Usage example: ActionReply reply; QVariantMap data; auto variantFd = QVariant::fromValue(UnixFileDescriptor(saveFile.handle())); data.insert(QStringLiteral("fd"), variantFd); reply.setData(data); return reply; REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns