kossebau updated this revision to Diff 66989. kossebau added a comment.
update to @dhaumann's first review: - drop wrong change for loop starting at 1 - use plain array for shortcutTitleToColumnMap REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261?vs=66949&id=66989 BRANCH morerangebasedforloops REVISION DETAIL https://phabricator.kde.org/D24261 AFFECTED FILES src/kaboutapplicationpersonmodel_p.cpp src/kedittoolbar.cpp src/kgesture.cpp src/kmainwindow.cpp src/kshortcutseditor.cpp src/kswitchlanguagedialog_p.cpp src/ktoolbar.cpp src/ktoolbarhandler.cpp src/kxmlguiclient.cpp src/kxmlguifactory_p.cpp To: kossebau, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns