pino added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:113
> case KFilePlacesModel::RecentlySavedType:
> - m_groupName = i18nc("@item", "Recently Saved");
> + m_groupName = i18nc("@item", "Recent");
> break;
this string needs a context, as "recent" basically leaves translators clueless
on what it refers to and/or where it is used
> kfileplacesmodel.h:139
> + */
> + KBookmark bookmarkForUrl(const QUrl &searchUrl);
>
this method must be const
REPOSITORY
R241 KIO
BRANCH
arcpatch-D7446
REVISION DETAIL
https://phabricator.kde.org/D7446
To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: pino, meven, trickyricky26, andreask, huftis, svenmauch,
kde-frameworks-devel, spoorun, andreaska, gregormi, markg, alexeymin, broulik,
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio,
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,
mikesomov
