ppeter added inline comments.

INLINE COMMENTS

> executablefileopendialog.cpp:58
> +
> +    if (mode == OnlyExecute) {
> +        connect(executeButton, &QPushButton::clicked, 
> [=]{done(ExecuteFile);});

if (mode == OnlyExecute)
    connect(executeButton, ...)
  else if (mode == OpenAsExecute)
    ...

looks better :)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

Reply via email to