bruns created this revision. bruns added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision.
REVISION SUMMARY In case many consecutive files are skipped in a directory, the recursive next() implementation recursed for every file, i.e. calling itself repeatedly. Instead, loop over all directory items until either a file or directory is found which should be indexed, or there are no more items left. Move the "shouldIndexHidden" variable out of the loop, as it is invariant. TEST PLAN ctest -R filtereddiriterator REPOSITORY R293 Baloo BRANCH iterative_filtereddiriterator REVISION DETAIL https://phabricator.kde.org/D24502 AFFECTED FILES src/file/filtereddiriterator.cpp To: bruns, #baloo Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
