meven added a comment.
In D23523#547265 <https://phabricator.kde.org/D23523#547265>, @dfaure wrote: > Looks fine, but it seems that the uploaded diff is only the delta compared to the previous diff, not the overall change. Anyhow, feel free to push both. It was on purpose to have two clean commits : add a new API, use it in the second commit. REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns