kossebau added inline comments. INLINE COMMENTS
> zzag wrote in plasmawindowmanagement_interface.cpp:741 > Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in > KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file. > > Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here? KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in the commit message: "No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by someone with detailed knowledge about disabling implementation, if wanted." I tried to add it, but too much API got deprecated yet still kept being used internally. So a version-levelled disabling of implementation is not yet possible, first needs more cleanup of the internal usages. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
