elvisangelaccio added a comment.
+1 INLINE COMMENTS > trashimpl.cpp:1091 > + KIO::UDSEntry entry; > + entry.clear(); > + Is this really needed? We just created `entry`. > trashimpl.cpp:1094 > + // refresh list of trashes and get the list of files in them > + const TrashedFileInfoList fileInfoList = list(); > + coding style: local variables never start with an uppercase. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
