ngraham added a comment.
In D24773#551245 <https://phabricator.kde.org/D24773#551245>, @meven wrote: > I would argue that "Disk space usage" and "Size" might be confusing to users. A folder size is the size of his content idiomatically. > That is our current usage of Size field for folders that is weird : My Image folder Size is "42 elements". > That is a paper cut that all new Plasma users have to learn "Size for folders is a content description" : not very intuitive. > We may want to in fact rename this field for folders to "Content" and keep Size for actual disk usage size (except in details view Size column of course). Personally I would prefer it if we could actually calculate the total of a folder's contents: https://bugs.kde.org/show_bug.cgi?id=158090 I tried to do this once and found that it was possible, but would need a lot of work to ensure adequate performance, and probably a lot of caching. I come from the macOS world where this is implemented and has no appreciable performance penalty whatsoever so I know it's possible. However this is probably unrelated to the current patch. Regarding this patch, I think the "Size" field for the trash should always show the total on-disk size of what's in the trash, regardless of the above, because the question that the user is looking to answer is, "How much space am I going to get back if I empty the trash right now?" For that, we need to always show the on-disk size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
