dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > KDECompilerSettings.cmake:208 > +set(CMAKE_C_STANDARD 90) > +set(CMAKE_CXX_STANDARD_REQUIRED 11) > That's not how it works. You want set(CMAKE_CXX_STANDARD 11) set(CMAKE_CXX_STANDARD_REQUIRED TRUE) Note however that these require CMake >= 3.1, while ECM says `cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)`. I do however thing that ECM *should* require 3.1. I doubt it's been tested on 2.8.x in ages, and 3.1 is really a common requirement these days. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
