dfaure added a comment.
This commit completely breaks the davgroupware resource for me (to access kolab calendars via CALDAV). REPORT requests get a 400 Bad Request error from the server. 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: ============ Sending Header: 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "REPORT /calendars/dfa...@kdab.com/0a9636a30e83-8c02805b740e-0a0dee75/ HTTP/1.1" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Host: caldav.kdab.com" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Connection: keep-alive" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.34 (KHTML, like Gecko) akonadi_davgroupware_resource_11/5.12.2 Safari/534.34" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Pragma: no-cache" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Cache-control: no-cache" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Accept: text/html, text/*;q=0.9, image/jpeg;q=0.9, image/png;q=0.9, image/*;q=0.9, */*;q=0.8" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Accept-Encoding: gzip, deflate, x-gzip, x-deflate" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Accept-Charset: utf-8,*;q=0.5" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Accept-Language: en-US,en;q=0.9" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Content-Type: text/xml" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Depth: 1" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Authorization: Basic [snipped" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Depth: 1" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery: "Content-Type: text/xml; charset=utf-8" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendBody: "<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<calendar-query xmlns=\"urn:ietf:params:xml:ns:caldav\">\n <prop xmlns=\"DAV:\">\n <getetag xmlns=\"DAV:\"/>\n <resourcetype xmlns=\"DAV:\"/>\n </prop>\n <filter xmlns=\"urn:ietf:params:xml:ns:caldav\">\n <comp-filter xmlns=\"urn:ietf:params:xml:ns:caldav\" name=\"VCALENDAR\">\n <comp-filter xmlns=\"urn:ietf:params:xml:ns:caldav\" name=\"VEVENT\"/>\n </comp-filter>\n </filter>\n</calendar-query>" 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::readResponseHeader: 2019-10-22T12:35:17 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::readResponseHeader: ============ Received Status Response: 2019-10-22T12:35:17 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::readResponseHeader: "HTTP/1.1 400 Bad Request" I think the problem is that the request has two Content-Type headers. The second one is added by the code we are now entering, line 2603, because of the modified if(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
