vkrause added a comment.
In general I think this looks very good already! The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being consumed? If this is purely used for display, maybe let's just replace the entire string in there by QSslCipher::name()? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
