ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Good stuff.

INLINE COMMENTS

> FeedbackOverlay.qml:63
> +                } else {
> +                    statusLabel.text = i18nc("Label for the busy indicator 
> which should only be shown when the entry has been given some unknown or 
> invalid status.", "Invalid or unknown state. Please report this to the KDE 
> Community in a bug report.");
> +                }

Bonus points for showing a link that actually takes you to 
https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this error 
condition is present

REPOSITORY
  R304 KNewStuff

BRANCH
  better-inline-feedback-for-item-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25189

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to