ahmadsamir added inline comments. INLINE COMMENTS
> jobuidelegate.cpp:365 > > sslMetaData.value(QStringLiteral("ssl_cipher_bits")).toInt(), > - > KSslInfoDialog::errorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors")))); > + > KSslInfoDialog::certificateErrorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors")))); > kid->exec(); Nitpick, wouldn't QLatin1String be better here? c.f. Marc Mutz's talk about QStringLiteral and QLatin1String: https://youtu.be/Ov7s0GgBbOQ?t=2806 > ksslinfodialog.cpp:263 > } > > +QList<QList<QSslError::SslError>> > KSslInfoDialog::certificateErrorsFromString(const QString &errorsString) Nitpick, shouldn't there be a "// static" comment like the other method? Wouldn't a QVector be better here (QVector<QList<QSslError::SslError>>)? that is IIUC what the QList docs and [1] are saying. [1]https://marcmutz.wordpress.com/effective-qt/containers/ REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolasfella Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns