ngraham added a comment.
In D25334#563841 <https://phabricator.kde.org/D25334#563841>, @ndavis wrote: > Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixed: > Not extending to the edge: F7768790: Screenshot_20191117_171047.png <https://phabricator.kde.org/F7768790> This was originally fixed by D19745 <https://phabricator.kde.org/D19745>, but that got reverted in 2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff <https://phabricator.kde.org/R120:2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff> because it caused other regressions that the patch author never returned to correct. We'd need to revisit this and do it in a regression-free manner. > Something about this feels wrong: F7768797: Screenshot_20191117_171225.png <https://phabricator.kde.org/F7768797> I agree. IMO double-width panels need to increase the size of the icons by default, because having a grid rather than a row is just awful and encourages the use of like 20 icons. We get many bug reports about people wanting this changed by default: https://bugs.kde.org/show_bug.cgi?id=360333 It's easily worked around locally by adding `iconSize=2` to `~/.config/plasma-org.kde.plasma.desktop-appletsrc` in the section that has `extraItems=` in it. It's a pretty trivial solution that works fairly well as the icons scale themselves down when the panel is shorter. Looks like this with a double-height panel: F7769037: Screenshot_20191117_183648.png <https://phabricator.kde.org/F7769037> Maybe worth investigating. > Same here: F7768799: Screenshot_20191117_171323.png <https://phabricator.kde.org/F7768799> Looks like a lack of adequate side margins. This code is super fragile, sadly. I can give it a look-see. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
