dfaure created this revision. dfaure added reviewers: mart, davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY KDeclarative::setupBindings() is deprecated, replaced calls with its implementation (setupContext + static setupEngine call), but see comment about whether we can be sure this is done only once per engine, as requested by the setupEngine API. It's 100% equivalent to the old code though, can't be worse. KPackage::contentsHash is deprecated, replaced call with implementation. Depends on D25433 <https://phabricator.kde.org/D25433> for the KActionCollection::changed signal. TEST PLAN Builds REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25434 AFFECTED FILES CMakeLists.txt src/declarativeimports/core/corebindingsplugin.cpp src/plasma/package.cpp src/plasmaquick/configview.cpp src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp To: dfaure, mart, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
