meven added inline comments.

INLINE COMMENTS

> kdirmodel.h:78
> +     * Otherwise, this is equivalent to dirLister()->openUrl(url, flags)
> +     * @param url   the URL of the directory whose contents should be 
> listed. The item for this directory will NOT be shown, the model starts at 
> its children.
> +     *              If the URL is an empty QUrl, the model will display a 
> root "/" node.

Would it make sense to instead of interpreting QUrl(), OpenUrlFlag would 
include a ShowRoot flag ?
I really like enums are they are explicit from the callee perspective.
Then it could call expandAllParentsUntil directly, this would allow in a single 
call to openUrl with a shown root node.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to