aspotashev added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:93
> maybe it would make sense to check for BSD instead?
> I don't know much about BSD, but I'd expect the shebang to work there as well.

I think it's better to minimize platform-specific if-endifs and make CMake code 
clean rather  than micro-optimize per platform.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

Reply via email to